-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add banner to DeviceBrowser when device limit reached #2670
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2670 +/- ##
==========================================
+ Coverage 39.69% 39.78% +0.09%
==========================================
Files 539 535 -4
Lines 18993 18790 -203
Branches 4465 4408 -57
==========================================
- Hits 7539 7476 -63
+ Misses 11454 11314 -140
Flags with carried forward coverage won't be shown. Click here to find out more.
|
My branch has total number of devices in a Vue data prop, so indeed will be easy to grab! |
Can be rebased on top of #2677 and use |
e80f1d0
to
e682c34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by @knolleary on release call.
Reviewed the additional changes from @Pezmc - happy to merge |
Description
This is part of the Team Types work. It adds the standard banner to the DeviceBrowser component and disabled the 'add device' button if the device limit has been reached.
Except... it doesn't quite work yet. Given the work around Device pagination, the DeviceBrowser is getting a bunch of rework in parallel. The current code doesn't appear to have the 'total number of devices in this team' baked into it. If I go about adding that, it'll insta-clash badly with the pagination work. So this is a placeholder PR to get the bulk of this work in - and the final piece can be updated when the pagination work lands.
Alternatively, if the pagination work is delayed, it will be a quick task to add the right logic here and get this merged and deal with the clashes later.