Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Limit Banner Improvements #2683

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Aug 31, 2023

Description

Keeps track of added/deleted devices so the banner can display/hide.

Screen.Recording.2023-08-31.at.13.04.42.mov

Related Issue(s)

#2670

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from knolleary August 31, 2023 11:07
@Pezmc Pezmc mentioned this pull request Aug 31, 2023
6 tasks
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #2683 (82508e8) into main (e682c34) will decrease coverage by 35.08%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #2683       +/-   ##
===========================================
- Coverage   74.76%   39.68%   -35.08%     
===========================================
  Files         232      539      +307     
  Lines        9541    18996     +9455     
  Branches     1986     4466     +2480     
===========================================
+ Hits         7133     7539      +406     
- Misses       2408    11457     +9049     
Flag Coverage Δ
backend 74.76% <ø> (ø)
frontend 2.15% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
frontend/src/components/DevicesBrowser.vue 0.00% <0.00%> (ø)
...rc/components/banners/FeatureUnavailableToTeam.vue 0.00% <ø> (ø)

... and 392 files with indirect coverage changes

@knolleary knolleary merged commit d925767 into main Sep 1, 2023
4 of 5 checks passed
@knolleary knolleary deleted the 2531-improve-device-limit-ux-improvements branch September 1, 2023 12:10
knolleary added a commit that referenced this pull request Sep 1, 2023
Device Limit Banner Improvements (backport #2683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants