-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push Snapshots Though Devops Pipelines #2818
Conversation
I may request an info/help button get added next to the "Select Action" form row label. I'd like to it detail (one/two sentences) each of the options. I've managed to decipher what each of them means, but not sure it would be intuitive to all users. |
This is why I should be using the factory here...
Codecov Report
@@ Coverage Diff @@
## main #2818 +/- ##
==========================================
- Coverage 39.82% 39.76% -0.06%
==========================================
Files 540 556 +16
Lines 19215 19837 +622
Branches 4551 4705 +154
==========================================
+ Hits 7653 7889 +236
- Misses 11562 11948 +386
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the backend side. One small update needed around logging.
Also to note we have two active PRs with migrations included - this one and #2738.
As it stands, #2738 must be merged first to ensure the migration ordering is preserved. That is the order I'm expecting these PRs to land in. If, for any reason, 2738 is delayed, we'll need to fixup the migration filenames.
6c13ad3
to
d66cb27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight rewording for the dialog
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
@Pezmc looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge when green
The test failure is not related to this PR and can be seen on main as far back as https://github.com/flowforge/flowforge/pull/2738/files, @hardillb and I are looking into the root cause, but there's no need to block this PR so merging away. |
Description
Marked draft as I'd like some UI feedback from @joepavitt (can be completed in a follow up though!).
Edit: And test failures
Key features:
Edit Pipeline Stage
Improved Names
Select Snapshot to Deploy
Related Issue(s)
Fixes #2651, #2600
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label