Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api docs to pipeline stage deploy end point #2838

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

knolleary
Copy link
Member

Adds api docs to the pipeline stage deploy end point

@knolleary knolleary linked an issue Sep 27, 2023 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2838 (2935ae3) into main (bf7c1bf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2838   +/-   ##
=======================================
  Coverage   39.76%   39.76%           
=======================================
  Files         556      556           
  Lines       19841    19841           
  Branches     4706     4706           
=======================================
  Hits         7890     7890           
  Misses      11951    11951           
Flag Coverage Δ
backend 75.52% <ø> (ø)
frontend 2.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
forge/ee/routes/pipeline/index.js 79.81% <ø> (ø)

@Pezmc
Copy link
Contributor

Pezmc commented Sep 27, 2023

This will need to be rebased to see the test fixes. Will merge after #2818.

Base automatically changed from feat-2651-push-snapshots to main September 27, 2023 16:09
@Pezmc Pezmc force-pushed the 2654-pipeline-deploy-api-docs branch from 2e980ff to 1f7b2c9 Compare September 27, 2023 16:39
@knolleary
Copy link
Member Author

7 test failures related to the pipeline api - although only 1 when I run locally. Regardless... investigating.

@knolleary
Copy link
Member Author

Ah yes - running with -b locally means it only tells me about the first failure 🤦🏻 ... that mystery solved. Still investigating.

@knolleary
Copy link
Member Author

Tests should be fixed. Whilst the schema defaulted to body.sourceSnapshotId being optional, it still expected a request body to be present, even if empty.

@knolleary
Copy link
Member Author

Setting body.required = false seems to really upset fastify and causes issues in completely unrelated routes.

Have changed the approach to specifying the type of body as ['object', 'null'] which appears to keep everyone happy.

@knolleary
Copy link
Member Author

Tests related to this PR all passing... failures related to issues on main persist.

Once they are resolved, will rebase and force push

@knolleary knolleary merged commit 715864e into main Sep 28, 2023
5 checks passed
@knolleary knolleary deleted the 2654-pipeline-deploy-api-docs branch September 28, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automating DevOps Pipeline Execution through API
2 participants