Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If empty deny list allow storing #3232

Merged
merged 1 commit into from
Dec 19, 2023
Merged

If empty deny list allow storing #3232

merged 1 commit into from
Dec 19, 2023

Conversation

hardillb
Copy link
Contributor

fixes #3188

Description

Unable to clear the Prevent Install of External nodes section of the Palette Settings.

Related Issue(s)

#3188

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 1.15 milestone Dec 19, 2023
@hardillb hardillb self-assigned this Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4b355e1) 40.41% compared to head (35d1862) 40.41%.
Report is 2 commits behind head on main.

Files Patch % Lines
forge/db/controllers/ProjectTemplate.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3232      +/-   ##
==========================================
- Coverage   40.41%   40.41%   -0.01%     
==========================================
  Files         587      587              
  Lines       21544    21546       +2     
  Branches     5176     5177       +1     
==========================================
  Hits         8707     8707              
- Misses      12837    12839       +2     
Flag Coverage Δ
backend 76.83% <0.00%> (-0.01%) ⬇️
frontend 1.95% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit d9ce170 into main Dec 19, 2023
6 of 7 checks passed
@knolleary knolleary deleted the fix-palette-denylist-3188 branch December 19, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to clear 'Exclude nodes by filename' setting
2 participants