Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async and transactional issues in code base #3812

Merged
merged 3 commits into from
May 2, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #3735

Description

  • Adds missing awaits in code and in tests
  • Passes options object (which may, or may not have a transaction associated) to the hasInstance and hasDevice functions

Related Issue(s)

#3735

#3716 (comment)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl linked an issue May 2, 2024 that may be closed by this pull request
@Steve-Mcl Steve-Mcl requested a review from knolleary May 2, 2024 09:50
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.14%. Comparing base (2c2a7aa) to head (14f0197).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3812   +/-   ##
=======================================
  Coverage   79.14%   79.14%           
=======================================
  Files         278      278           
  Lines       12495    12495           
  Branches     2768     2770    +2     
=======================================
  Hits         9889     9889           
  Misses       2606     2606           
Flag Coverage Δ
backend 79.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 561e3e0 into main May 2, 2024
8 checks passed
@knolleary knolleary deleted the 3735-async-and-transactional-issues-in-code-base branch May 2, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: async / transactional issues in code base
2 participants