Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlalachemy 2 #6461

Merged
merged 12 commits into from
Feb 27, 2024
Merged

Sqlalachemy 2 #6461

merged 12 commits into from
Feb 27, 2024

Conversation

greenape
Copy link
Member

@greenape greenape commented Feb 26, 2024

Closes #6066

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

This should make everything work again with sqlalchemy 2+.

@greenape greenape added bug Something isn't working FlowMachine Issues related to FlowMachine FlowDB Issues related to FlowDB dependencies Pull requests that update a dependency file flowkit-jwt-generator labels Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.94%. Comparing base (9cec1a5) to head (90d46a5).

Files Patch % Lines
flowmachine/flowmachine/core/sqlalchemy_utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6461      +/-   ##
==========================================
- Coverage   92.95%   92.94%   -0.02%     
==========================================
  Files         264      264              
  Lines       10304    10303       -1     
  Branches      835      835              
==========================================
- Hits         9578     9576       -2     
  Misses        598      598              
- Partials      128      129       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 26, 2024

Passing run #21750 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge branch 'master' into sqlalachemy-2
Project: FlowAuth Commit: 90d46a5281
Status: Passed Duration: 00:47 💡
Started: Feb 27, 2024 10:19 AM Ended: Feb 27, 2024 10:20 AM

Review all test suite changes for PR #6461 ↗︎

Copy link
Member

@jc-harrison jc-harrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label Feb 27, 2024
@mergify mergify bot merged commit 78101f9 into master Feb 27, 2024
42 checks passed
@mergify mergify bot deleted the sqlalachemy-2 branch February 27, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file FlowDB Issues related to FlowDB flowkit-jwt-generator FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlowMachine is incompatible with SQLAlchemy 2.0
2 participants