Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invalid_cell_info table and change exclude constraint on cell_info #6627

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

jc-harrison
Copy link
Member

@jc-harrison jc-harrison commented May 24, 2024

Closes #6626

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

  • Changes the exclude constraint on infrastructure.cell_info to ensure cell ID is unique across all simultaneously-valid cells, not just WHERE to_include.
  • Adds a new table infrastructure.invalid_cell_info, with similar structure to infrastructure.cell_info but fewer constraints, to hold any rows from cell information files that are not valid entries in infrastructure.cell_info (including cells with null or duplicate cell IDs).

🚀 This description was created by Ellipsis for commit c837b57

Summary:

This PR modifies the exclusion constraint on infrastructure.cell_info and introduces a new table infrastructure.invalid_cell_info to enhance data integrity and tracking of invalid cell records.

Key points:

  • Modified EXCLUDE constraint on infrastructure.cell_info for cell ID uniqueness across all valid cells.
  • Introduced infrastructure.invalid_cell_info table for storing invalid cell records.
  • Updated CHANGELOG.md.

Generated with ❤️ by ellipsis.dev

Copy link

cypress bot commented May 24, 2024

Passing run #22854 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge branch 'master' into refactor-cell-info-tables
Project: FlowAuth Commit: 23c33bf563
Status: Passed Duration: 00:46 💡
Started: Jun 13, 2024 11:51 AM Ended: Jun 13, 2024 11:52 AM

Review all test suite changes for PR #6627 ↗︎

@jc-harrison jc-harrison added FlowDB Issues related to FlowDB refactoring labels May 24, 2024
@jc-harrison jc-harrison requested a review from greenape May 24, 2024 11:39
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.11%. Comparing base (3a1d263) to head (23c33bf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6627   +/-   ##
=======================================
  Coverage   77.11%   77.11%           
=======================================
  Files         268      268           
  Lines       10590    10590           
  Branches      856      856           
=======================================
  Hits         8166     8166           
  Misses       2169     2169           
  Partials      255      255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on aa4537b in 1 minute and 53 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_EwMkq0EIsV6GLdSf


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jc-harrison jc-harrison added the ready-to-merge Label indicating a PR is OK to automerge label Jun 11, 2024
@mergify mergify bot merged commit 5bf759c into master Jun 13, 2024
40 checks passed
@mergify mergify bot deleted the refactor-cell-info-tables branch June 13, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowDB Issues related to FlowDB ready-to-merge Label indicating a PR is OK to automerge refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow duplicates in infrastructure.cell_info
2 participants