-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add invalid_cell_info table and change exclude constraint on cell_info #6627
Conversation
Passing run #22854 ↗︎
Details:
Review all test suite changes for PR #6627 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6627 +/- ##
=======================================
Coverage 77.11% 77.11%
=======================================
Files 268 268
Lines 10590 10590
Branches 856 856
=======================================
Hits 8166 8166
Misses 2169 2169
Partials 255 255 ☔ View full report in Codecov by Sentry. |
7ca6f7b
to
aa4537b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on aa4537b in 1 minute and 53 seconds
More details
- Looked at
20
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_EwMkq0EIsV6GLdSf
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
70bd304
to
c837b57
Compare
Closes #6626
I have:
Description
infrastructure.cell_info
to ensure cell ID is unique across all simultaneously-valid cells, not justWHERE to_include
.infrastructure.invalid_cell_info
, with similar structure toinfrastructure.cell_info
but fewer constraints, to hold any rows from cell information files that are not valid entries ininfrastructure.cell_info
(including cells with null or duplicate cell IDs).Summary:
This PR modifies the exclusion constraint on
infrastructure.cell_info
and introduces a new tableinfrastructure.invalid_cell_info
to enhance data integrity and tracking of invalid cell records.Key points:
EXCLUDE
constraint oninfrastructure.cell_info
for cell ID uniqueness across all valid cells.infrastructure.invalid_cell_info
table for storing invalid cell records.CHANGELOG.md
.Generated with ❤️ by ellipsis.dev