Fix bug reported in issue 727 #729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calling fluid_synth_free_voice_by_kill_LOCAL(), two problems occur: 1)The value returned by fluid_synth_get_active_voice_count() never returns back to 0. 2)SoundFont samples are not unref'd properly, and therefore if an attempt is made to unload the SoundFont, the deferred unload timer is started, and fluid_synth_sfunload_callback() unsuccessfully tries to unload the SoundFont forever. These 2 issues are fixed by this commit.
…s(). initialize voice->sample to NULL in fluid_voice_stop().
derselbst
reviewed
Dec 30, 2020
| @@ -4629,6 +4628,9 @@ fluid_synth_check_finished_voices(fluid_synth_t *synth) | |||
| else if(synth->voice[j]->overflow_rvoice == fv) | |||
| { | |||
| fluid_voice_overflow_rvoice_finished(synth->voice[j]); | |||
|
|
|||
| /* Decrement voice count */ | |||
| synth->active_voice_count--; | |||
There was a problem hiding this comment.
For consistency I think it would be better to move this call into fluid_voice_overflow_rvoice_finished().
There was a problem hiding this comment.
But I see you did it earlier and the unit tests failed. Perhaps you could just add a small comment to explain why the decrement must be put here.
added 2 commits
December 30, 2020 13:31
…shed(), fluid_synth_check_finished_voices
|
Kudos, SonarCloud Quality Gate passed! |
|
Closed in favor of #736 which is based on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues reported in #727