Skip to content

Update SQLite quickstart.md to caution reserved words as column names #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2025

Conversation

ethanpil
Copy link
Contributor

@ethanpil ethanpil commented Mar 9, 2025

Description

I have updated the SQLite quickstart.md to caution using reserved words as column names. I was having inexplicable build errors until I guessed that this might be the issue.

I suggest that FF team in the future to include a list of words that are problematic.

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

I suggest that FF team in the future to include a list of works that are problematic.
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Added a bit more info on why to avoid and added an official link to see the full list of reserved keywords.
Copy link
Collaborator

@pinkeshmars pinkeshmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ethanpil we have addded a bit more info and added link to see list of reserved keywords. Thank you so much for raising the PR!

@ethanpil
Copy link
Contributor Author

@pinkeshmars No problem of course, you can do as is best. However, I want to point out that the two specific examples I provided of type and data are what was causing my error and neither is listed on the SQLite page you are linking to...

@pinkeshmars
Copy link
Collaborator

@pinkeshmars No problem of course, you can do as is best. However, I want to point out that the two specific examples I provided of type and data are what was causing my error and neither is listed on the SQLite page you are linking to...

Ya, I just updated the link to this 'https://en.wikipedia.org/wiki/List_of_SQL_reserved_words' which has those keywords.

@ethanpil
Copy link
Contributor Author

That list seems better, but do you think it will be confusing for some users since that page specifically does not list SQLite? Not trying to nitpick, but from a user or newbie perspective it might be confusing. I'll let you take it from there. Thanks for taking my suggestion into consideration.

@pinkeshmars
Copy link
Collaborator

That list seems better, but do you think it will be confusing for some users since that page specifically does not list SQLite? Not trying to nitpick, but from a user or newbie perspective it might be confusing. I'll let you take it from there. Thanks for taking my suggestion into consideration.

You're correct that it doesn't list SQLite. Actually, the TYPE and DATA are not reserved keywords in SQLite. However, using these terms as column names can still lead to issues due to potential ambiguities or conflicts in certain contexts. To minimize such risks and enhance code clarity, it's always advisable to avoid any SQL-related keywords and opt for more descriptive column names.​ Thanks for your suggestion. I'll update the info a bit.

@pinkeshmars pinkeshmars merged commit 53aee79 into FlutterFlow:main Mar 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants