-
Notifications
You must be signed in to change notification settings - Fork 108
Update SQLite quickstart.md to caution reserved words as column names #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I suggest that FF team in the future to include a list of works that are problematic.
|
Added a bit more info on why to avoid and added an official link to see the full list of reserved keywords.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ethanpil we have addded a bit more info and added link to see list of reserved keywords. Thank you so much for raising the PR!
@pinkeshmars No problem of course, you can do as is best. However, I want to point out that the two specific examples I provided of |
Ya, I just updated the link to this 'https://en.wikipedia.org/wiki/List_of_SQL_reserved_words' which has those keywords. |
That list seems better, but do you think it will be confusing for some users since that page specifically does not list SQLite? Not trying to nitpick, but from a user or newbie perspective it might be confusing. I'll let you take it from there. Thanks for taking my suggestion into consideration. |
You're correct that it doesn't list SQLite. Actually, the TYPE and DATA are not reserved keywords in SQLite. However, using these terms as column names can still lead to issues due to potential ambiguities or conflicts in certain contexts. To minimize such risks and enhance code clarity, it's always advisable to avoid any SQL-related keywords and opt for more descriptive column names. Thanks for your suggestion. I'll update the info a bit. |
Description
I have updated the SQLite quickstart.md to caution using reserved words as column names. I was having inexplicable build errors until I guessed that this might be the issue.
I suggest that FF team in the future to include a list of words that are problematic.
Type of change