Skip to content

Writing Custom Code #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Writing Custom Code #59

merged 8 commits into from
Jul 23, 2024

Conversation

PoojaB26
Copy link
Collaborator

@PoojaB26 PoojaB26 commented Jul 22, 2024

Description

Provide a brief overview of what this documentation update is about. Explain what sections or topics are being added or revised.

Linear ticket and magic word
Fixes DEVR-333
Fixes DEVR-354
Fixes DEVR-355
Fixes DEVR-343

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot requested a review from johnbhiggins7 July 22, 2024 09:26
@PoojaB26 PoojaB26 requested review from pinkeshmars and removed request for johnbhiggins7 July 22, 2024 09:44
Copy link
Collaborator

@pinkeshmars pinkeshmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PoojaB26 Added review comments.

@@ -0,0 +1,4 @@
{
"label": "Adding Customization",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about keeping it just 'Customization'?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it "Customizations" instead.

compilation errors. To do so, click the **Compile Code** button.


<figure>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the 'Has Compilation Errors' section (right side) of this image, the arrow is slightly misaligned.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

In the following example, we have a Custom Action that takes an `onError(searchKeyword)` callback
action with an Action Parameter `searchKeyword`. This means that the custom action will provide this search keyword back to the callback action when it calls it.

![explain-callback-action.png](imgs%2Fexplain-callback-action.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrows seem to be missing in this image!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed

width: '100%'
}}>
<iframe
src="https://demo.arcade.software/zBBJiIaTBpoBWErwvpbd?embed&show_copy_link=true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this arcade, step 3 and 4 seem to the same.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

PoojaB26 and others added 3 commits July 23, 2024 15:37
@PoojaB26
Copy link
Collaborator Author

@pinkeshmars comments addressed!

@pinkeshmars pinkeshmars merged commit dc2bacf into main Jul 23, 2024
@PoojaB26 PoojaB26 deleted the pooja/custom-code branch August 1, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants