-
Notifications
You must be signed in to change notification settings - Fork 109
Writing Custom Code #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PoojaB26 Added review comments.
@@ -0,0 +1,4 @@ | |||
{ | |||
"label": "Adding Customization", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about keeping it just 'Customization'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping it "Customizations" instead.
compilation errors. To do so, click the **Compile Code** button. | ||
|
||
|
||
<figure> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the 'Has Compilation Errors' section (right side) of this image, the arrow is slightly misaligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
In the following example, we have a Custom Action that takes an `onError(searchKeyword)` callback | ||
action with an Action Parameter `searchKeyword`. This means that the custom action will provide this search keyword back to the callback action when it calls it. | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arrows seem to be missing in this image!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, fixed
width: '100%' | ||
}}> | ||
<iframe | ||
src="https://demo.arcade.software/zBBJiIaTBpoBWErwvpbd?embed&show_copy_link=true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this arcade, step 3 and 4 seem to the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Co-authored-by: pinkeshmars <71133091+pinkeshmars@users.noreply.github.com>
@pinkeshmars comments addressed! |
Description
Provide a brief overview of what this documentation update is about. Explain what sections or topics are being added or revised.
Linear ticket and magic word
Fixes DEVR-333
Fixes DEVR-354
Fixes DEVR-355
Fixes DEVR-343
Type of change