Fixed empty query params #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibahjoe
commented
Dec 27, 2020
| String resolverPath(String routeName, String path) { | ||
| final uri = Uri.parse(path); | ||
| return uri.resolve(routeName).path; | ||
| return routeName; |
There was a problem hiding this comment.
Previous implementation loses the query params information because Uri.path returns only the path without the query params etc. i.e for a url /signup?email=email.com, the old implementation returned /signup which doesn't have the query params any more. This wasn't caught by the tests because we were passing /signup?email=email.com directly into parser.selectRoute
I am not sure what this line uri.resolve(routeName).path does tho.
I have updated the tests also.
There was a problem hiding this comment.
I figured what it does from a failing test. I have updated the implementation to Uri.toString
updated path resolution reverted resolverPath updated final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
So, this pull request addresses 2 issues i noticed. First,
ModularArguments.uriwas null which in turn meantfragment,queryParamsandqueryParamsAllwere all empty. The tests didn't catch this becasue they were checking the route returned instead ofroute.args(I updated the tests too).Secondly, the query params information did not exist in
Modular.argsbecause ofresolverPath(String routeName, String path)method. It was removing the query params. i updated it toUri.toString.