Skip to content

fix navigate function to have two different behaviors #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2021
Merged

fix navigate function to have two different behaviors #377

merged 1 commit into from
Apr 25, 2021

Conversation

Mex978
Copy link
Contributor

@Mex978 Mex978 commented Apr 23, 2021

Description

This PR tries to correct the implementation of #363 on navigate() function. The changes cause the navigate function to have two different behaviors:

  • When used within a module to navigate between the pages of that module, it works similarly to a pushNamed which just inserts the page into the navigation stack
  • When used to navigate between modules, not internally, navigate replaces the entire navigation stack and navigates to the new module

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • This change requires a documentation update

@evandrmb evandrmb mentioned this pull request Apr 23, 2021
Closed
@jacobaraujo7 jacobaraujo7 merged commit 3318d46 into Flutterando:master Apr 25, 2021
@jacobaraujo7
Copy link
Contributor

@all-contributors please add @Mex978 for code

@allcontributors allcontributors bot mentioned this pull request Apr 25, 2021
Merged
@allcontributors
Copy link
Contributor

@jacobaraujo7

I've put up a pull request to add @Mex978! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mex978 @jacobaraujo7