Skip to content

fix(leaderboard chart): fix query on many to many relationship #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020
Merged

fix(leaderboard chart): fix query on many to many relationship #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 40 additions & 33 deletions src/services/leaderboard-stat-getter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,48 +10,55 @@ function LeaderboardStatGetter(model, modelRelationship, params, options) {
const schema = Schemas.schemas[model.name];
const schemaRelationship = Schemas.schemas[modelRelationship.name];
let associationAs = schema.name;
const associationFound = _.find(
modelRelationship.associations,
(association) => association.target.name === model.name,
);

_.each(modelRelationship.associations, (association) => {
if (association.target.name === model.name && association.as) {
associationAs = association.as;
}
});
if (associationFound && associationFound.as) {
associationAs = associationFound.as;
}

const groupBy = `${associationAs}.${labelField}`;

function getAggregateField() {
// NOTICE: As MySQL cannot support COUNT(table_name.*) syntax, fieldName cannot be '*'.
const fieldName = aggregateField || schemaRelationship.primaryKeys[0]
const fieldName = aggregateField
|| schemaRelationship.primaryKeys[0]
|| schemaRelationship.fields[0].field;
return `${schemaRelationship.name}.${Orm.getColumnName(schema, fieldName)}`;
return `"${modelRelationship.tableName}"."${Orm.getColumnName(schema, fieldName)}"`;
}

let joinQuery;
if (associationFound.associationType === 'BelongsToMany') {
const joinTableName = associationFound.through.model.tableName;
joinQuery = `INNER JOIN "${joinTableName}"
ON "${modelRelationship.tableName}"."${associationFound.sourceKeyField}" = "${joinTableName}"."${associationFound.foreignKey}"
INNER JOIN "${model.tableName}" AS "${associationAs}"
ON "${associationAs}"."${associationFound.targetKeyField}" = "${joinTableName}"."${associationFound.otherKey}"
`;
} else {
const foreignKeyField = associationFound.source
.rawAttributes[associationFound.foreignKey].field;
joinQuery = `INNER JOIN "${model.tableName}" AS "${associationAs}"
ON "${associationAs}"."${associationFound.targetKeyField}" = "${modelRelationship.tableName}"."${foreignKeyField}"
`;
}

this.perform = () => modelRelationship
.unscoped()
.findAll({
attributes: [
[options.sequelize.fn(aggregate, options.sequelize.col(getAggregateField())), 'value'],
],
include: [{
model,
attributes: [labelField],
as: associationAs,
required: true,
}],
group: groupBy,
order: [[options.sequelize.literal('value'), 'DESC']],
limit,
raw: true,
})
.then((records) => {
records = records.map((data) => {
data.key = data[groupBy];
delete data[groupBy];
return data;
});

return { value: records };
});
const query = `
SELECT ${aggregate}(${getAggregateField()}) as "value", ${groupBy} as "key"
FROM "${modelRelationship.tableName}"
${joinQuery}
GROUP BY ${groupBy}
ORDER BY "value" DESC
LIMIT ${limit}
`;


this.perform = () => options.connections[0].query(query, {
type: model.sequelize.QueryTypes.SELECT,
})
.then((records) => ({ value: records }));
}

module.exports = LeaderboardStatGetter;