Skip to content

Fixed 404 user not found error for service account #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025
+9 −8
Merged

Fixed 404 user not found error for service account #210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c70131
Fixed 404 user not found error for service account
vahagn-yavruyan May 2, 2025
0d68711
Added descriptive comment for the fixes
vahagn-yavruyan May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions packages/data-sdk/src/stores/AuthenticationStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,7 @@ export class AuthenticationStore implements IAuthenticationStore {
}
}

async loginWithToken(
token: string,
refreshToken?: string,
skipUserFetch = false
) {
async loginWithToken(token: string, refreshToken?: string) {
const tokenData = JSON.parse(decode(token.split(".")[1]));
try {
let userId: string | undefined;
Expand All @@ -187,7 +183,7 @@ export class AuthenticationStore implements IAuthenticationStore {
userId = tokenData["formant:claims"].userId;
}

if (userId && this._currentUser?.id !== userId && !skipUserFetch) {
if (userId && this._currentUser?.id !== userId) {
const result = await fetch(`${this._apiUrl}/v1/admin/users/${userId}`, {
method: "GET",
headers: {
Expand All @@ -196,10 +192,15 @@ export class AuthenticationStore implements IAuthenticationStore {
},
});
const data = await result.json();
if (result.status !== 200) {
if (result.status === 404) {
// this can happen if the token doesn't have access to its own user, like in the embed case
// ignore this error
this._currentUser = undefined;
} else if (result.status !== 200) {
throw new Error(data.message);
} else {
this._currentUser = data;
}
this._currentUser = data;
}
this._token = token;
this._waitingForAuth.forEach((_) => _(true));
Expand Down