This repository was archived by the owner on Feb 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Animation support #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th unique constraints
# Conflicts: # README.md
Eww. I'll poke at it tonight! |
Repro'd it here. What the hell is going on there? I'll try to track down the regression |
I've confirmed that this craziness only happens against React 15. But...why?? |
This breaks React 15 rendering: <script>
// Sanity-check the component loaded...
setTimeout(function () {
var content = document.querySelector("#content");
content.innerHTML = content.innerHTML ||
"If you can see this, something is broken (or JS is not enabled)!";
}, 500);
</script> It's in the demo html files of many of our OSS projects. We should probably check that this doesn't happen elsewhere. @boygirl @kenwheeler @coopy |
Going to merge, post-review comments appreciated! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the README diff for how the animation API works!
This PR depended on the new constraint removal support in our fork of Autolayout.js.
/cc @boygirl @eastridge @kenwheeler @divmain et al