Skip to content
This repository was archived by the owner on Feb 19, 2022. It is now read-only.

Conversation

tptee
Copy link
Contributor

@tptee tptee commented Jun 5, 2016

See the README diff for how the animation API works!

This PR depended on the new constraint removal support in our fork of Autolayout.js.

/cc @boygirl @eastridge @kenwheeler @divmain et al

@coveralls
Copy link

coveralls commented Jun 5, 2016

Coverage Status

Coverage increased (+1.9%) to 86.348% when pulling a232027 on feature/animation-support into 301c1b7 on master.

@kenwheeler
Copy link

This looks awesome. On local, when running builder run dev, it sometimes does the intial layout, but resizing the window isn't keeping the positions synced. This is on a fresh pull.
screen shot 2016-06-06 at 8 33 38 am

@tptee
Copy link
Contributor Author

tptee commented Jun 6, 2016

Eww. I'll poke at it tonight!

@tptee
Copy link
Contributor Author

tptee commented Jun 7, 2016

Repro'd it here. What the hell is going on there? I'll try to track down the regression

@tptee
Copy link
Contributor Author

tptee commented Jun 7, 2016

I've confirmed that this craziness only happens against React 15. But...why??

@tptee
Copy link
Contributor Author

tptee commented Jun 11, 2016

This breaks React 15 rendering:

<script>
  // Sanity-check the component loaded...
  setTimeout(function () {
    var content = document.querySelector("#content");
    content.innerHTML = content.innerHTML ||
      "If you can see this, something is broken (or JS is not enabled)!";
  }, 500);
</script>

It's in the demo html files of many of our OSS projects. We should probably check that this doesn't happen elsewhere. @boygirl @kenwheeler @coopy

@coveralls
Copy link

coveralls commented Jun 11, 2016

Coverage Status

Coverage decreased (-0.6%) to 83.849% when pulling 2184a24 on feature/animation-support into 301c1b7 on master.

@tptee
Copy link
Contributor Author

tptee commented Jun 30, 2016

Going to merge, post-review comments appreciated!

@tptee tptee merged commit 01891a9 into master Jun 30, 2016
@tptee tptee deleted the feature/animation-support branch June 30, 2016 04:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants