fix callback type check #218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArtemAstakhov 👋 hi, thanks for opening a PR. Curious if you could add a bit of context on this change? It additionally encouraged me to make an issue to for upgrading to TS 4, #220 . Which was recently released. The "end goal" around this part of the code would be to hopefully avoid the need for the casting's( |
|
We closed #220 with #228 and updated TS to v4.1. We also opened a new PR, #232, that is attempting a similar solution, but we are currently have compile issues and need to dig into them. Thank you again @ArtemAstakhov for this PR to get the 🧠 wheels moving, cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.