Skip to content

Conversation

stefvhuynh
Copy link
Contributor

@stefvhuynh stefvhuynh commented Mar 19, 2021

  • Migrates codesandbox examples to this repo
  • Converts them into typescript

TODO before merge

  • We need to figure out the developer experience. In order for this to work in code sandbox, the examples/ folder needs to be self-contained with it's own package.json. As such, we need to import react-swipeable from npm instead of just importing from src/. Thus, in order to develop on the examples, a developer needs to either yarn link the package or change the import manually. However, we then get extra copies of react errors. We should sort this out before merging.

@stefvhuynh stefvhuynh requested a review from hartzis March 25, 2021 20:03
@hartzis hartzis merged commit 29d03df into main May 13, 2021
@hartzis hartzis deleted the migrate-examples branch February 18, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants