Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The bootstrap background images are baaaack #442

Closed
boutell opened this issue Sep 3, 2012 · 27 comments
Closed

The bootstrap background images are baaaack #442

boutell opened this issue Sep 3, 2012 · 27 comments
Labels

Comments

@boutell
Copy link

boutell commented Sep 3, 2012

Previously fixed in #6, this issue is back with the latest bootstrap tarball and font-awesome tarball as of today. The images and the font-based icons appear at the same time. I thought I had a text-shadow bug and went crazy looking for it (:

The workaround seems to be:

[class^="icon-"], [class*=" icon-"] {
background-image:none;
}

Note the second selector. Possibly that's new?

@yar0d
Copy link

yar0d commented Sep 4, 2012

Thanks for this workaround :-)

@luizkowalski
Copy link

another one: seyhunak/twitter-bootstrap-rails#357

@mtobias
Copy link

mtobias commented Oct 11, 2012

that workaround gives me a duplicate of the icon

@rostenkowski
Copy link

You have to check out the Bootstrap without the icon definitions...

@mtobias
Copy link

mtobias commented Oct 25, 2012

how do i access bootstrap without icon definitions?

@goofansu
Copy link

goofansu commented Dec 9, 2012

I'm using gem bootstrap-sass, and just commented the @import "bootstrap/sprites"; in vendor/assets/stylesheets/bootstrap/bootstrap.scss

In Gemfile:

gem 'bootstrap-sass', '~> 2.2.1.1'

@jclay
Copy link

jclay commented Dec 29, 2012

Thanks @goofansu.
I ended up the copying the contents of https://github.com/thomas-mcdonald/bootstrap-sass/blob/master/vendor/assets/stylesheets/bootstrap/bootstrap.scss into my application.css.scss file and commenting @import "bootstrap/sprites"; out. Works perfectly.

@goofansu
Copy link

@jclay Glad I could help. Happy New Year :)

@davegandy
Copy link
Member

Fixed in the new 3.0.

@goofansu
Copy link

goofansu commented Jan 3, 2013

@jclay rails-font-awesome supports the Newest 3.0, there is no need to comment out bootstrap-sass any more.

@jclay
Copy link

jclay commented Jan 3, 2013

Excellent. Thanks to everyone involved for a prompt resolution!

@davegandy
Copy link
Member

Are people still seeing this problem in 3.0?

@caarlos0
Copy link

caarlos0 commented Jan 4, 2013

I'm not with 3.0 yet..

On Thu, Jan 3, 2013 at 11:48 PM, davegandy notifications@github.com wrote:

Are people still seeing this problem in 3.0?


Reply to this email directly or view it on GitHubhttps://github.com//issues/442#issuecomment-11869416.

Atenciosamente,
Carlos Alexandro Becker
http://caarlos0.github.com/about

@emiyake
Copy link

emiyake commented Jan 16, 2013

I'm still having this problem with 3.0..
Screen Shot 2013-01-16 at 8 04 01 PM

@emiyake
Copy link

emiyake commented Jan 17, 2013

Yeap. I'll stick to that. Thanks.

@davegandy
Copy link
Member

People are still having this issue with 3.0.1? I've taken new pains to try to ensure this is not happening in the SCSS and SASS included. Please make sure you're using the most updated code.

@caarlos0
Copy link

updated code, delete caches and everything.. still happens... I put the hack and it works.

@davegandy
Copy link
Member

Interesting. I'm doing a background-image: none (among others), but that's not doing it for some odd reason. I'll see what I can do on the next release.

@davegandy davegandy reopened this Jan 17, 2013
@caarlos0
Copy link

try with an !important.

On Wed, Jan 16, 2013 at 11:30 PM, davegandy notifications@github.comwrote:

Interesting. I'm doing a background-image: none (among others), but that's
not doing it for some odd reason. I'll see what I can do on the next
release.


Reply to this email directly or view it on GitHubhttps://github.com//issues/442#issuecomment-12350265.

Atenciosamente,
Carlos Alexandro Becker
http://caarlos0.github.com/about

@davegandy
Copy link
Member

!important is bad. Breaks CSS for other folks using the library. This was specifically removed from 3.0.0.

@davegandy
Copy link
Member

@caarlos0 Can you put up an example and replicate somewhere I can look at? I want to investigate further.

@caarlos0
Copy link

http://208.68.36.164/index

It's in development ritght now. (just in portuguese)

Click in the button that saids "Cadastre-se gratuitamente agora!" (the
green one).

On Wed, Jan 16, 2013 at 11:36 PM, davegandy notifications@github.comwrote:

@caarlos0 https://github.com/caarlos0 Can you put up an example and
replicate somewhere I can look at? I want to investigate further.


Reply to this email directly or view it on GitHubhttps://github.com//issues/442#issuecomment-12350412.

Atenciosamente,
Carlos Alexandro Becker
http://caarlos0.github.com/about

@davegandy
Copy link
Member

The code I'm looking at there appears to be from 3.0.0, not 3.0.1. In 3.0.0, there were specific problems with white icons, which have been fixed in 3.0.1.

@caarlos0
Copy link

The top of my Gemfile.lock:


GIT
  remote: git://github.com/caarlos0/font-awesome-sass-rails.git
  revision: 05a5ed40489c7bf7fb0b1a7f6e40508aed5601f3
  specs:
    font-awesome-sass-rails (3.0.0.1)
      railties (>= 3.1.1)
      sass-rails (>= 3.1.1)

On Thu, Jan 17, 2013 at 12:21 AM, davegandy notifications@github.comwrote:

The code I'm looking at there appears to be from 3.0.0, not 3.0.1. In
3.0.0, there were specific problems with white icons, which have been fixed
in 3.0.1.


Reply to this email directly or view it on GitHubhttps://github.com//issues/442#issuecomment-12351475.

Atenciosamente,
Carlos Alexandro Becker
http://caarlos0.github.com/about

@caarlos0
Copy link

I'm using my own fork because of the issue #22, PR #23 (from font-awesome-sass-rails)

@mayankbatra
Copy link

Im facing the same problem in 3.0.2
Any workaround till then, im using bootstrap as an extension with css published already. Cant do much changes there.

@davegandy
Copy link
Member

Still happening in 3.1.1? Closing in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests