fixing test case for mixed-mode tests #3603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgrieser
requested changes
Sep 17, 2025
There was a problem hiding this comment.
Can you also add more of a description to this PR?
I'm also thinking that this is probably a testing improvement change rather than a bug fix, as a bug fix would imply that there's something wrong in "real" code, whereas this is really just to prevent us from reporting a false mixed-mode failure
normen662
added
testing improvement
alecgrieser
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a minimum supported version (for mixed mode testing) in a yamsql test case. This test broke the mixed mode testing affecting the releases 4.5.13.0 and 4.5.14.0 until it was discovered. The PR checks did not fail though it should have failed. Opened #3604 to track the test case issue.