Set codeCoverageData so that you can run it with tests #3605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of `fileTree` caused codeCoverageReport to have implicit dependences on every task that ran, but this is not what we want. I updated it to more directly depend on the jacoco output. I also updated it to explicitly mustRunAfter all test and jar tasks of the relevant sub projects. By using mustRunAfter instead of dependsOn, I think it should allow running codeCoverageReport without running jar or test, which will work better with the pull_request workflow, where we run the tests in different jobs, and bring in the results to run codeCoverageReport.
alecgrieser
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of
fileTreecaused codeCoverageReport to have implicit dependences on every task that ran, but this is not what we want. I updated it to more directly depend on the jacoco output. I also updated it to explicitly mustRunAfter all test and jar tasks of the relevant sub projects.By using mustRunAfter instead of dependsOn, I think it should allow running codeCoverageReport without running jar or test, which will work better with the pull_request workflow, where we run the tests in different jobs, and bring in the results to run codeCoverageReport.