-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Towards Julia v1.0 #81
Conversation
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
===========================================
+ Coverage 76.91% 99.16% +22.25%
===========================================
Files 16 12 -4
Lines 1360 598 -762
===========================================
- Hits 1046 593 -453
+ Misses 314 5 -309
Continue to review full report at Codecov.
|
There is a puzzling increase in coverage. Without changing essentially anything from v0.6 to v0.u we get ~22% in coverage. Seems like coverage.jl does not seem to be counting some big fraction of src code lines. Anybody from Coverage.jl perhaps can suggest what might be happening here? @IainNZ? |
The actual coverage numbers are generated by Julia itself - Coverage.jl just sends them to a service. I think there may be coverage issues in Julia 0.7 from what I've seen on slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some wrinkles to figure out with requirements (specifically FFTW and JLD2), but otherwise looks good.
Implements changes to comply with deprecations or change of syntax in
julia v0.7
.@glwagner: I suggest we make all code compatible with
v0.7
and then we split the physics modules from the mainFourierFlows.jl
code.