Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards Julia v1.0 #81

Merged
merged 11 commits into from
Sep 11, 2018
Merged

Towards Julia v1.0 #81

merged 11 commits into from
Sep 11, 2018

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Aug 10, 2018

Implements changes to comply with deprecations or change of syntax in julia v0.7.

@glwagner: I suggest we make all code compatible with v0.7 and then we split the physics modules from the main FourierFlows.jl code.

@navidcy navidcy requested a review from glwagner August 10, 2018 23:20
@coveralls
Copy link

coveralls commented Aug 10, 2018

Coverage Status

Coverage increased (+22.3%) to 99.164% when pulling 2f5fb0d on TowardsJulia1.0 into c6ab17a on master.

@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #81 into master will increase coverage by 22.25%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #81       +/-   ##
===========================================
+ Coverage   76.91%   99.16%   +22.25%     
===========================================
  Files          16       12        -4     
  Lines        1360      598      -762     
===========================================
- Hits         1046      593      -453     
+ Misses        314        5      -309
Impacted Files Coverage Δ
src/problemstate.jl 100% <ø> (ø) ⬆️
src/FourierFlows.jl 100% <ø> (ø) ⬆️
src/physics/verticallycosineboussinesq.jl 93.54% <100%> (+34.36%) ⬆️
src/physics/twodturb.jl 100% <100%> (+15.73%) ⬆️
src/physics/verticallyfourierboussinesq.jl 100% <100%> (+44.87%) ⬆️
src/diagnostics.jl 100% <100%> (ø) ⬆️
src/physics/traceradvdiff.jl 100% <100%> (ø) ⬆️
src/physics/kuramotosivashinsky.jl 100% <100%> (ø) ⬆️
src/utils.jl 98.68% <100%> (-0.26%) ⬇️
src/domains.jl 100% <100%> (+2.53%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ab17a...8f709b5. Read the comment docs.

@navidcy
Copy link
Member Author

navidcy commented Aug 16, 2018

There is a puzzling increase in coverage. Without changing essentially anything from v0.6 to v0.u we get ~22% in coverage. Seems like coverage.jl does not seem to be counting some big fraction of src code lines. Anybody from Coverage.jl perhaps can suggest what might be happening here? @IainNZ?

@IainNZ
Copy link

IainNZ commented Aug 16, 2018

The actual coverage numbers are generated by Julia itself - Coverage.jl just sends them to a service. I think there may be coverage issues in Julia 0.7 from what I've seen on slack.

@navidcy navidcy mentioned this pull request Sep 11, 2018
Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wrinkles to figure out with requirements (specifically FFTW and JLD2), but otherwise looks good.

@glwagner glwagner merged commit 7ae3202 into master Sep 11, 2018
@navidcy navidcy deleted the TowardsJulia1.0 branch October 7, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants