pull #8
Merged
pull #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ashing. I have been hesitant to do this because optimized-away uniforms are usually a sign of a problem rather than something to be silently ignored, but a recent case with HueMod in a constant-white input convinced me otherwise. I do think it is a bit weird that optimizing away uniform reads also optimizes away the whole uniform, seeing as how it's part of the shader interface, but apparently that's how it works. Also not sure this is the nicest solution to the problem (see comment), but it's unclear what the nicer solution would be.
This is somewhat strange, since many places very explicitly want URLs, but since all the URL constructors are deprecated, the URI class is the only officially supported way to manipulate URLs, so just convert to URLs as late as possible in general.
Apparently, there are still drivers that require all OpenGL activity to occur on the thread that created the window. The main offender is MacOS.
I'm not sure why this was done to begin with, but I suspect it was to run disposal on the same thread as rendering, for some reason. That shouldn't be necessary now that rendering happens on the AWT thread to begin with, though.
Not sure if this should be considered "normal" or not.
# Conflicts: # build.xml # src/haven/Config.java # src/haven/MainFrame.java # src/haven/Screenshooter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.