Only update /etc/default/grub in OEM kernel update instructions if 'quiet splash' are not included #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't update this line if quiet splash is present. Fixes https://community.frame.work/t/amd-oem-kernel-update-procedure-breaks-hibernate-by-updating-grub-cmdline-linux-default-in-etc-default-grub/44726
rathboma
changed the title
|
I am keeping this open, I think there is real merit to it. Going to try and make some time to put together some thoughts on how to be address this. Your pull request in on point for folks using hibernation, etc. I am putting a pin this, but keeping it open to circle back. |
|
Patched added. Thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't update this line if quiet splash is present.
Fixes https://community.frame.work/t/amd-oem-kernel-update-procedure-breaks-hibernate-by-updating-grub-cmdline-linux-default-in-etc-default-grub/44726
This:
quiet splashis included on the defaults lineWhy?
Improvements?
It might be good to be more sophisticated with this check and warn users if something will be overwritten.