Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SQL Server specific provider into separate assembly or namespace #6

Open
FransBouma opened this issue Nov 29, 2014 · 2 comments
Open

Refactor SQL Server specific provider into separate assembly or namespace #6

FransBouma opened this issue Nov 29, 2014 · 2 comments
Labels
High priority

Comments

@FransBouma
Copy link
Owner

To make it possible to support multiple database types, the sql server specific code has to be refactored into a separate assembly. Make sure it builds on top of a series of base classes as a lot of the code likely will be re-used by providers for other DBs
@FransBouma FransBouma mentioned this issue Nov 29, 2014
Open
@FransBouma FransBouma changed the title Refactor SQL Server specific provider into separate assembly Refactor SQL Server specific provider into separate assembly or namespace Jan 30, 2015
@FransBouma
Copy link
Owner Author

It's probably easier to simply keep the code in the same assembly so people don't have to reference multiple dlls. NHibernate does this too.

FransBouma added a commit that referenced this issue Jan 30, 2015
@FransBouma
Started work on #6
0067b95 
Massive chaos still in the code base, not done combing through the
SqlClient code to split it up. Hit some roadblocks as there are a few
public types in the SqlClient namespace which can't be changed to
another namespace so the chosen namespace will likely change again
before release (or the breaking change marked in the code is accepted as
such).

Work started to make it easier for #1 to be implemented as that's
currently not possible without lots of code duplication and this
refactor has to be done anyway.
FransBouma added a commit that referenced this issue Jan 30, 2015
@FransBouma
Added remark regarding the code being compilable
fc7bd97 
The code base currently doesn't compile. This is due to the massive
refactoring under way for #6.
@FransBouma
Copy link
Owner Author

Second part of major refactoring. Code compiles d045dee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
High priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FransBouma