Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gui: Workbench TabBar "More" button should be placed on the end and always visible #13720

Closed
2 tasks done
kadet1090 opened this issue Apr 29, 2024 · 0 comments · Fixed by #13721
Closed
2 tasks done

Gui: Workbench TabBar "More" button should be placed on the end and always visible #13720

kadet1090 opened this issue Apr 29, 2024 · 0 comments · Fixed by #13721
Labels
Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Topic: User Interface Issue related UI/UX Type: Feature FR for improvements or new features

Comments

@kadet1090
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

This is issue that was "introduced" by the #13508 PR and is split from the #13602 issue where we debated the change to placement. The issue that original PR solved was to make sure that the "+" button is always easy to access. I think that proper solution should be to implement this to work like browser tabs, i.e. the "+" button is always at the end of tabs but also always visible. This will work naturally as we are very used to such behavior.

Full version info

0.22dev

Subproject(s) affected?

None

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue Apr 29, 2024
@kadet1090
Gui: Move more button to the end WB TabBar
0590b51 
This changes back placement of the "more" button of the WB TabBar to be
at the end, where it should be naturally placed. In order to ensure that
it is always visible the control was reworked to show this button always
after the tab bar widget which now is dynamically sized. This is
behavior that is well known from browsers.

This commit also ensures that active workbench is always visible in the
TabBar by adding additional temporary tab when necessary. This tab will
automatically dissapear when not needed.

Fixes: FreeCAD#13720
Fixes: FreeCAD#13630
@kadet1090 kadet1090 mentioned this issue Apr 29, 2024
Merged
@maxwxyz maxwxyz added Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Topic: User Interface Issue related UI/UX Type: Feature FR for improvements or new features labels Apr 30, 2024
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 4, 2024
@kadet1090
Gui: Move more button to the end WB TabBar
ee47055 
This changes back placement of the "more" button of the WB TabBar to be
at the end, where it should be naturally placed. In order to ensure that
it is always visible the control was reworked to show this button always
after the tab bar widget which now is dynamically sized. This is
behavior that is well known from browsers.

This commit also ensures that active workbench is always visible in the
TabBar by adding additional temporary tab when necessary. This tab will
automatically dissapear when not needed.

Fixes: FreeCAD#13720
Fixes: FreeCAD#13630
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 4, 2024
@kadet1090
Gui: Move more button to the end WB TabBar
8a458d8 
This changes back placement of the "more" button of the WB TabBar to be
at the end, where it should be naturally placed. In order to ensure that
it is always visible the control was reworked to show this button always
after the tab bar widget which now is dynamically sized. This is
behavior that is well known from browsers.

This commit also ensures that active workbench is always visible in the
TabBar by adding additional temporary tab when necessary. This tab will
automatically dissapear when not needed.

Fixes: FreeCAD#13720
Fixes: FreeCAD#13630
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 5, 2024
@kadet1090
Gui: Move more button to the end WB TabBar
1ecc22c 
This changes back placement of the "more" button of the WB TabBar to be
at the end, where it should be naturally placed. In order to ensure that
it is always visible the control was reworked to show this button always
after the tab bar widget which now is dynamically sized. This is
behavior that is well known from browsers.

This commit also ensures that active workbench is always visible in the
TabBar by adding additional temporary tab when necessary. This tab will
automatically dissapear when not needed.

Fixes: FreeCAD#13720
Fixes: FreeCAD#13630
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 5, 2024
@kadet1090
Gui: Move more button to the end WB TabBar
7e1c500 
This changes back placement of the "more" button of the WB TabBar to be
at the end, where it should be naturally placed. In order to ensure that
it is always visible the control was reworked to show this button always
after the tab bar widget which now is dynamically sized. This is
behavior that is well known from browsers.

This commit also ensures that active workbench is always visible in the
TabBar by adding additional temporary tab when necessary. This tab will
automatically dissapear when not needed.

Fixes: FreeCAD#13720
Fixes: FreeCAD#13630
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 6, 2024
@kadet1090
Gui: Move more button to the end WB TabBar
1a46f51 
This changes back placement of the "more" button of the WB TabBar to be
at the end, where it should be naturally placed. In order to ensure that
it is always visible the control was reworked to show this button always
after the tab bar widget which now is dynamically sized. This is
behavior that is well known from browsers.

This commit also ensures that active workbench is always visible in the
TabBar by adding additional temporary tab when necessary. This tab will
automatically dissapear when not needed.

Fixes: FreeCAD#13720
Fixes: FreeCAD#13630
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 6, 2024
@kadet1090
Gui: Move more button to the end WB TabBar
133f41e 
This changes back placement of the "more" button of the WB TabBar to be
at the end, where it should be naturally placed. In order to ensure that
it is always visible the control was reworked to show this button always
after the tab bar widget which now is dynamically sized. This is
behavior that is well known from browsers.

This commit also ensures that active workbench is always visible in the
TabBar by adding additional temporary tab when necessary. This tab will
automatically dissapear when not needed.

Fixes: FreeCAD#13720
Fixes: FreeCAD#13630
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 6, 2024
@kadet1090
Gui: Move more button to the end WB TabBar
ce74d04 
This changes back placement of the "more" button of the WB TabBar to be
at the end, where it should be naturally placed. In order to ensure that
it is always visible the control was reworked to show this button always
after the tab bar widget which now is dynamically sized. This is
behavior that is well known from browsers.

This commit also ensures that active workbench is always visible in the
TabBar by adding additional temporary tab when necessary. This tab will
automatically dissapear when not needed.

Fixes: FreeCAD#13720
Fixes: FreeCAD#13630
kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 12, 2024
@kadet1090
Gui: Move more button to the end WB TabBar
3405939 
This changes back placement of the "more" button of the WB TabBar to be
at the end, where it should be naturally placed. In order to ensure that
it is always visible the control was reworked to show this button always
after the tab bar widget which now is dynamically sized. This is
behavior that is well known from browsers.

This commit also ensures that active workbench is always visible in the
TabBar by adding additional temporary tab when necessary. This tab will
automatically dissapear when not needed.

Fixes: FreeCAD#13720
Fixes: FreeCAD#13630
@github-actions github-actions bot mentioned this issue May 15, 2024
Closed
adrianinsaval added a commit to Ondsel-Development/FreeCAD that referenced this issue May 25, 2024
@adrianinsaval
Backport upstream PR FreeCAD#13721 - Gui: Move more button to the end…
b1157c2 
… WB TabBar

Gui: Add our ToolBarArea enumeration

This refactors implementation of toolbars in menu / status bar a bit. It
introduces enum with all possible areas like it is in Qt that can be
later used to decide what to do based on toolbar placement.

Gui: Move more button to the end WB TabBar

This changes back placement of the "more" button of the WB TabBar to be
at the end, where it should be naturally placed. In order to ensure that
it is always visible the control was reworked to show this button always
after the tab bar widget which now is dynamically sized. This is
behavior that is well known from browsers.

This commit also ensures that active workbench is always visible in the
TabBar by adding additional temporary tab when necessary. This tab will
automatically dissapear when not needed.

Fixes: FreeCAD#13720
Fixes: FreeCAD#13630

Gui: Add proper tooltip to Workbench TabBar tab

Gui: Adjust sizing of Workbench TabBar when changing orientation

This should fix issues when toolbar containing Workbench TabBar suddenly
(or not) changes orientation. It also fixes size policies so toolbar
resizes properly and does not cause window to grow.

Fixes: FreeCAD#13286

Gui: Use RTL layout when Wb Tab Bar is placed in right corner

Right corner is placed to the right edge of screen, so its natural
growth occours on the left side. Basically it is Right to Left order and
so in that case the "end" is actually on left and so TabBar should grow
in that direction.

Unfortunately it is not possible to simply use RTL Qt feature to handle
that case as it would result in reverse order of workbenches (people will still
read it in LTR order) and icons on the right which is not wanted. That's
custom support is introduced.

Gui: Fix wrong orientation of workbench tab bar after start

This replaces old mechanism that was based on storing tab bar
orientation in user settings with one that delays initialization by half
of a second to ensure that toolbar is placed where in right place.

Gui: Reuse QActions for workbench activation

This fixes segfault that can occour due to keeping reference to QAction
that is supposed to change workbench.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Topic: User Interface Issue related UI/UX Type: Feature FR for improvements or new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gui: Move more button to the end WB TabBar kadet1090/FreeCAD
2 participants
@kadet1090 @maxwxyz