Fix shiboken2@5.15.5 patches #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently files in shiboken source repository have DOS line endings, so embed the patches here, and get rid of the broken files.
|
thanks for submitting this PR. i'll probably submit another PR after CI checks finish and attempt to update formula to use external patch files. personally i don't like embedding the patches directly in the formula file but if it's the only way we can get this to work then i'll stick with inlining the patches in the formula file. |
|
issue with building bottles due to deletion of bottle block and conflict with revision number but formula builds 🙏 from source. better than what is currently available. will merge anyway to allow fix of broken shiboken2 formula. thanks again for submitting the PR. |
This was referenced Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently files in shiboken source repository have DOS line endings,
so embed the patches here, and get rid of the broken files.
In case git still manages to mangle the filenames, then patches could be pulled here: