Skip to content

Conversation

andysun2015
Copy link
Contributor

Description of changes:

  • Align folder structure with other library.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chinglee-iot
chinglee-iot previously approved these changes Sep 6, 2021
paulbartell
paulbartell previously approved these changes Sep 7, 2021
Copy link
Contributor

@paulbartell paulbartell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of your makefiles are missing new lines at the end of the file. This is generally good practice.

I would also suggest adding a .gitattributes file so that contributors on windows platforms will commit "\n" line endings rather than "\r\n".

https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings

Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
@andysun2015 andysun2015 dismissed stale reviews from paulbartell and chinglee-iot via 171ca22 September 8, 2021 00:10
andysun2015 and others added 18 commits September 8, 2021 08:11
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
Co-authored-by: Paul Bartell <paul.bartell@gmail.com>
@andysun2015
Copy link
Contributor Author

Some of your makefiles are missing new lines at the end of the file. This is generally good practice.

I would also suggest adding a .gitattributes file so that contributors on windows platforms will commit "\n" line endings rather than "\r\n".

https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings

I've added the .gitattributes file for line ending correction.
Please refer to this commit.

@andysun2015 andysun2015 merged commit cefe8c6 into FreeRTOS:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants