Skip to content

Conversation

pramithkv
Copy link
Contributor

@pramithkv pramithkv commented Dec 6, 2021

Remove tickless idle feature dependency with INCLUDE_vTaskSuspend

Description

There was a build error in eTaskConfirmSleepModeStatus() when configUSE_TICKLESS_IDLE is enabled.
This was forcing user to enable INCLUDE_vTaskSuspend (set as 1).

This Pull request removes the need for INCLUDE_vTaskSuspend to be set 1 when configUSE_TICKLESS_IDLE is enabled.

All codes accessing xSuspendedTaskList is now moved under#if ( INCLUDE_vTaskSuspend == 1 )checks.

Test Steps

Use any of the FreeRTOS demo project.
Make these changes in FreeRTOSConfig.h file -

#define configUSE_TICKLESS_IDLE 	1
#define INCLUDE_vTaskSuspend		0

Build fails without changes in this PR

Related Issue

https://forums.freertos.org/t/tickless-idle-mode-and-vtasksuspend-dependency/13977

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pramithkv pramithkv requested a review from a team as a code owner December 6, 2021 12:29
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #422 (d0c1b5b) into main (052e364) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files           4        4           
  Lines        1274     1274           
  Branches      343      343           
=======================================
  Hits         1174     1174           
  Misses         53       53           
  Partials       47       47           
Flag Coverage Δ
unittests 92.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052e364...d0c1b5b. Read the comment docs.

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
@pramithkv pramithkv requested a review from aggarg December 7, 2021 15:05
@cobusve cobusve merged commit 4c4089b into FreeRTOS:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants