Address edge cases and add tests #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarw13
reviewed
Sep 15, 2020
|
|
||
| #define isOpenBracket_( x ) ( ( ( x ) == '{' ) || ( ( x ) == '[' ) ) | ||
| #define isCloseBracket_( x ) ( ( ( x ) == '}' ) || ( ( x ) == ']' ) ) | ||
| /* NB. The numeric values of the open and close bracket pairs differ by 2. */ |
There was a problem hiding this comment.
What does "NB" stand for?
There was a problem hiding this comment.
May be esoteric for readers?
There was a problem hiding this comment.
We use e.g. and i.e. often enough. I'll keep it.
aggarw13
reviewed
Sep 15, 2020
| CUT_AFTER_OBJECT_START_MARKER_LENGTH ); | ||
| TEST_ASSERT_EQUAL( JSONPartial, jsonStatus ); | ||
|
|
||
| jsonStatus = JSON_Validate( CUT_AFTER_KEY, |
There was a problem hiding this comment.
With the changes to the parser, a key without a value is considered illegal, not partial. The case is also covered by one of the new tests.
There was a problem hiding this comment.
Also, I put the test back with the other illegal tests.
yourslab
approved these changes
Sep 15, 2020
cobusve
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves 3 edge cases and adds unit tests to prevent future regressions.