You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This requires a malicious server.
The column number was not checked causing potential buffer overflows accessing columns in the results.
Detect and close the connection.
tds: Fill up correctly upper part of numeric
A large NUMERIC (like NUMERIC(76, 0)) could cause a buffer overflow using "packet" array. This as the formulae to compute higher index was wrong. Correct the formulae.
In reality this is unlikely to happen, no current server support such a large NUMERIC so you probably would need a malicious server.
Also add a test for it using a really large number.
Caution
Do not use Source code links below, they are auto generated and broken.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Added commit
tds: Avoid compute results to cause overflow
This requires a malicious server.
The column number was not checked causing potential buffer overflows accessing columns in the results.
Detect and close the connection.
tds: Fill up correctly upper part of numeric
A large NUMERIC (like NUMERIC(76, 0)) could cause a buffer overflow using "packet" array. This as the formulae to compute higher index was wrong. Correct the formulae.
In reality this is unlikely to happen, no current server support such a large NUMERIC so you probably would need a malicious server.
Also add a test for it using a really large number.
Caution
Do not use Source code links below, they are auto generated and broken.
This discussion was created from the release FreeTDS 1.5.22 minor release.
All reactions