Fix Exception and StackTrace is ignored for logs #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwadrox
changed the title
I modified the type from Exception to Object because if we wrap with an Exception we might lose the original type of the Exception Frezyx#198
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 99.78% 99.67% -0.12%
==========================================
Files 25 14 -11
Lines 467 305 -162
==========================================
- Hits 466 304 -162
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
Should i include the Exception object as well? |
|
@Frezyx can you take a look? :) |
Frezyx
approved these changes
Mar 19, 2024
|
Hello @qwadrox 👋 Great PR! Thank you for contributing ❤️ |
This was
linked to
issues
Mar 19, 2024
This was referenced Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#198
#183
#122