Update UploadBehavior.php

[davidyell]

When trying to upload an image with incorrect exif data this method will throw a warning. This is because it also validates the Exif data against the spec to make sure it's valid.

exif_read_data() also validates EXIF data tags according to the EXIF specification (» http://exif.org/Exif2-2.PDF, page 20).

You'll get this warning.

Warning (2): exif_read_data(main_vienna_6.jpg): Incorrect APP1 Exif Identifier Code [APP/Plugin/Upload/Model/Behavior/UploadBehavior.php, line 1502]

Images with invalid exif information are still uploaded though, so it doesn't have any functional impact. However if devs are logging errors this will fill up an error log pretty quickly.

[coveralls]

Coverage remained the same when pulling f3803e6 on davidyell:patch-1 into 14004cf on josegonzalez:master.

[davidyell]

Relates to #221

[davidyell]

What are your thoughts on this @josegonzalez ? Travis is just failing for PHPCS, but is silencing this error really that bad?

It would suck that Travis would fail PHPCS for every run though.

[josegonzalez]

I think you can do something like NOQA or similar?

[davidyell]

Didn't mean to remove that branch!

[davidyell]

I haven't been able to find anything on the NOQA thing, but I did find this.

$ phpcs --config-set ignore_warnings_on_exit 1
https://github.com/squizlabs/PHP_CodeSniffer/wiki/Configuration-Options#ignoring-warnings-when-generating-the-exit-code

Not sure if this will impact the project by letting bad code through though on future PR's.