Skip to content

Fix migration docs #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2018
Merged

Fix migration docs #95

merged 2 commits into from
May 5, 2018

Conversation

kunicmarko20
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #93
License MIT

@kunicmarko20 kunicmarko20 changed the base branch from master to 1.x May 4, 2018 20:29
ElectricMaxxx
ElectricMaxxx requested changes May 4, 2018
View reviewed changes
Copy link
Contributor

@ElectricMaxxx ElectricMaxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think, that this is right. In App, which we target from my pov, we should propose remove -> require. In a bundle you can use update.

@kunicmarko20
Copy link
Contributor Author

So, should I replace it with remove -> require? then we do not need that first part with composer change

@kunicmarko20 kunicmarko20 requested a review from ElectricMaxxx May 5, 2018 19:19
ElectricMaxxx
ElectricMaxxx approved these changes May 5, 2018
View reviewed changes
Copy link
Contributor

@ElectricMaxxx ElectricMaxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) cool.

@kunicmarko20 kunicmarko20 merged commit 40ed66f into FriendsOfSymfony:1.x May 5, 2018
@kunicmarko20 kunicmarko20 deleted the migration_docs_fix branch May 5, 2018 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElectricMaxxx ElectricMaxxx ElectricMaxxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunicmarko20 @ElectricMaxxx