Make command lazy #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kunicmarko20
commented
May 4, 2018
kunicmarko20
commented
| Q | A |
|---|---|
| Bug fix? | yes/no |
| New feature? | yes/no |
| BC breaks? | yes/no |
| Deprecations? | yes/no |
| Fixed tickets | #27 |
| License | MIT |
ElectricMaxxx
requested changes
May 4, 2018
|
Not sure we can? we still support symfony 2.8? This is on |
ElectricMaxxx
requested changes
May 5, 2018
| @@ -7,7 +7,7 @@ | |||
| <services> | |||
| <service id="fos_ck_editor.command.installer" class="FOS\CKEditorBundle\Command\CKEditorInstallerCommand"> | |||
| <argument type="service" id="fos_ck_editor.installer" /> | |||
| <tag name="console.command" /> | |||
| <tag name="console.command" command="ckeditor:install" /> | |||
There was a problem hiding this comment.
wouldn't that mean, we can omit the name definition in the class now?
There was a problem hiding this comment.
I am not sure, don't we still need it for sf 2.8?
There was a problem hiding this comment.
as any sf version < 3.4 doesn't know how to read command="ckeditor:install" and will just ignore it.
There was a problem hiding this comment.
@ElectricMaxxx so?
ElectricMaxxx
approved these changes
May 6, 2018
kunicmarko20
added a commit
that referenced
this pull request
May 7, 2018
This reverts commit e9cf107.
ElectricMaxxx
pushed a commit
that referenced
this pull request
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.