Move autowiring aliases to XML files #2725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Feb 9, 2018
Resources/config/doctrine.xml
Outdated
| <argument>%fos_user.model.user.class%</argument> | ||
| </service> | ||
|
|
||
| <service id="FOS\UserBundle\Model\UserManagerInterface" alias="fos_user.user_manager" public="false" /> |
There was a problem hiding this comment.
this would not make it work for people not using Doctrine. We must add it in a file being always loaded
There was a problem hiding this comment.
@stof In which file should we add it ? A custom new one ?
| $container->setAlias('fos_user.util.email_canonicalizer', $config['service']['email_canonicalizer']); | ||
| $container->setAlias('fos_user.util.username_canonicalizer', $config['service']['username_canonicalizer']); | ||
| $container->setAlias('fos_user.util.token_generator', $config['service']['token_generator']); | ||
| $container->setAlias('FOS\UserBundle\Util\TokenGeneratorInterface', new Alias('fos_user.util.token_generator', false)); |
There was a problem hiding this comment.
please also move this one to the util.xml file
Readd missing part Add tokengenerator to util.xml
stof
changed the title
This allows having the autowiring alias defined even when not using Doctrine.
stof
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move aliases created in the FOSUserExtension to the proper XML service definition files.