Fix deprecations reported on Symfony 5.4 #3048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors reported by Swiftmailer classes in the DebugClassLoader are ignored as they won't be fixed (and they are not classified as indirect ones probably because of the non-namespaced classes).
This implementation relies on the old deprecated API of the encoders, so it might trigger deprecation warnings when testing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testsuite was disabling the reporting of deprecations (probably because of the swiftmailer mess), which caused me to miss some changes when adding support for Symfony 5.
In particular, the programmatic login was not properly creating the remember-me cookie when using the new authentication system.