Update PHPDoc for sfWebController::redirect() func #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can actually pass array to sfWebController::redirect() function as first parameter, but IDE wrongly highlights this as "Expected parameter of type 'string', 'array' provided".
mentalstring
approved these changes
May 12, 2021
spirit-q2
approved these changes
May 12, 2021
e1himself
reviewed
May 13, 2021
thirsch
approved these changes
May 14, 2021
The more precise the types are, the better IDE will help preventing errors. Co-authored-by: Ivan Voskoboinyk <ivan.voskoboinyk@gmail.com>
According to discussion: FriendsOfSymfony1#246 (comment)
alquerci
approved these changes
May 14, 2021
thePanz
approved these changes
May 25, 2021
|
@cmdeviant Thanks Pavel, merged! |
terdia
pushed a commit
to amboss-mededu/php-symfony1
that referenced
this pull request
May 28, 2021
According to discussion: FriendsOfSymfony1#246 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can actually pass array to sfWebController::redirect() function as first parameter, but IDE wrongly highlights this as "Expected parameter of type 'string', 'array' provided".