Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated libp2p set_max_buffer_size method call #1592

Closed
MitchTurner opened this issue Jan 8, 2024 · 0 comments
Closed

Remove deprecated libp2p set_max_buffer_size method call #1592

MitchTurner opened this issue Jan 8, 2024 · 0 comments
Assignees

Comments

@MitchTurner
Copy link
Member

Waiting on response from libp2p people here:
libp2p/rust-libp2p#5073

@MitchTurner MitchTurner changed the title Remove deprecated libp2p method call Remove deprecated libp2p set_max_buffer_size method call Jan 8, 2024
xgreenx added a commit that referenced this issue Jun 4, 2024
Closes #1592

This change improves and simplifies some aspects of the P2P service. It
also fixes the issue of not reconnecting to the reserved nodes when the
reserved node is restarted and got new IP.

- The change moves the reconnection handling into the `PeerReport`
behavior. It removes ping-ponging reserved peers between the primary
behavior and the `PeerReport` behavior and encapsulates the logic inside
the `PeerReport`. Also, it eliminates the timer and replaces it with the
queue of reconnections, reducing noise in logs(before, we had much more
trash errors).
- Added logs for cases when the dial fails. They are very helpful to
debug issues with connection.
- Simplified initialization of the `ConnectionTracker` and
`FuelAuthenticated`. It allows the reuse of libp2p built-in connections
builder.
- Removed the usage of the Mplex since it doesn't have a backpressure
mechanism. Now we use Yamux by default. It is breaking the change since
nodes with the old codebase can't connect to new nodes.
- Propagated `max_concurrent_streams` for request-response protocol.

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog

### Before requesting review
- [x] I have reviewed the code myself

---------

Co-authored-by: Hannes Karppila <hannes.karppila@gmail.com>
@xgreenx xgreenx self-assigned this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants