Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fuel-vm 0.33 with predicate estimation #1195

Merged
merged 36 commits into from
Jun 7, 2023

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented May 31, 2023

The change is based on #1072, so you can review it first to check the main changes for the predicate estimation. All other changes are from new breaking changes from the fuel-core 0.33.

The main changes:

  • Each transaction now should have at least one coin or message, so it affected all unit and integration tests to construct a valid transaction.
  • Contract id is affected by the new strategy of the root calculation. So it changed hardcoded values in several places.
  • Now, id and check_signature functions use ChainId instead of the ConsensusParametrs because of corresponding changes in the fuel-vm.
  • Removed the verify_tx_has_at_least_one_coin_or_message stage from the executor because it is done by the CheckedTransaction.
  • Transaction::precompute may return the error for Create transactions if the witness is not set.

possible-panther and others added 30 commits March 20, 2023 06:54
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>

# Conflicts:
#	crates/client/src/client/schema/tx/transparent_tx.rs
#	crates/fuel-core/src/executor.rs
#	crates/fuel-core/src/service/adapters/graphql_api.rs
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>

# Conflicts:
#	crates/fuel-core/src/executor.rs
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>

# Conflicts:
#	Cargo.toml
#	crates/client/assets/schema.sdl
#	crates/client/src/client/schema/chain.rs
#	crates/fuel-core/src/executor.rs
#	crates/services/producer/src/block_producer.rs
#	crates/types/src/services/executor.rs
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
(cherry picked from commit e4c6180)

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	bin/e2e-test-client/src/lib.rs
#	crates/client/assets/schema.sdl
#	crates/client/src/client/schema/chain.rs
# Conflicts:
#	Cargo.lock
#	crates/client/src/client/schema/primitives.rs
# Conflicts:
#	crates/client/src/client.rs
#	crates/fuel-core/src/schema/tx.rs
#	tests/tests/tx/txn_status_subscription.rs
Used `ChainId` instead of the `ConsensusParameters`
@xgreenx xgreenx changed the title Use fuel-vm 0.33 with predicate estiamtion Use fuel-vm 0.33 with predicate estimation May 31, 2023
@xgreenx xgreenx self-assigned this May 31, 2023
@xgreenx xgreenx requested a review from a team May 31, 2023 10:35
@xgreenx xgreenx marked this pull request as ready for review May 31, 2023 10:35
# Conflicts:
#	tests/tests/blocks.rs
#	tests/tests/tx.rs
#	tests/tests/tx/predicates.rs
#	tests/tests/tx/tx_pointer.rs
#	tests/tests/tx/txn_status_subscription.rs
#	tests/tests/tx/utxo_validation.rs
#	tests/tests/tx_gossip.rs
@xgreenx xgreenx merged commit 37f3475 into master Jun 7, 2023
@xgreenx xgreenx deleted the feature/predicate-estimation branch June 7, 2023 21:11
@xgreenx xgreenx mentioned this pull request Jun 13, 2023
xgreenx added a commit that referenced this pull request Jun 14, 2023
## What's Changed
* version compatibility cleanup by @Voxelot in
#1171
* Added example with custom query around the `fuel-core-client` by
@xgreenx in #1175
* Update to fuel-vm 0.32 (including wideint gas profiling) by @Dentosal
in #1173
* feat: Client primitives by @bvrooman in
#1144
* Improve executor config by @Voxelot in
#1185
* Added `contract_id` to the `ContractConfig` by @xgreenx in
#1184
* fix windows file name error by @firedpeanut in
#1176
* Make transaction status stream work by @freesig in
#1108
* Added `submit_and_await` endpoint to not miss the notifications by
@xgreenx in #1192
* feat: Use ID types in client api by @bvrooman in
#1191
* Use `fuel-vm 0.33` with predicate estimation by @xgreenx in
#1195
* Add transaction lifecycle diagram to the docs by @digorithm in
#1201
* sync with peers before producing blocks by @leviathanbeak in
#1169
* SMT storage key hashing by @xgreenx in
#1207

## New Contributors
* @firedpeanut made their first contribution in
#1176

**Full Changelog**:
v0.18.1...v0.19.0

---------

Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
crypto523 added a commit to crypto523/fuel-core that referenced this pull request Oct 7, 2024
## What's Changed
* version compatibility cleanup by @Voxelot in
FuelLabs/fuel-core#1171
* Added example with custom query around the `fuel-core-client` by
@xgreenx in FuelLabs/fuel-core#1175
* Update to fuel-vm 0.32 (including wideint gas profiling) by @Dentosal
in FuelLabs/fuel-core#1173
* feat: Client primitives by @bvrooman in
FuelLabs/fuel-core#1144
* Improve executor config by @Voxelot in
FuelLabs/fuel-core#1185
* Added `contract_id` to the `ContractConfig` by @xgreenx in
FuelLabs/fuel-core#1184
* fix windows file name error by @firedpeanut in
FuelLabs/fuel-core#1176
* Make transaction status stream work by @freesig in
FuelLabs/fuel-core#1108
* Added `submit_and_await` endpoint to not miss the notifications by
@xgreenx in FuelLabs/fuel-core#1192
* feat: Use ID types in client api by @bvrooman in
FuelLabs/fuel-core#1191
* Use `fuel-vm 0.33` with predicate estimation by @xgreenx in
FuelLabs/fuel-core#1195
* Add transaction lifecycle diagram to the docs by @digorithm in
FuelLabs/fuel-core#1201
* sync with peers before producing blocks by @leviathanbeak in
FuelLabs/fuel-core#1169
* SMT storage key hashing by @xgreenx in
FuelLabs/fuel-core#1207

## New Contributors
* @firedpeanut made their first contribution in
FuelLabs/fuel-core#1176

**Full Changelog**:
FuelLabs/fuel-core@v0.18.1...v0.19.0

---------

Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants