Process Upload transaction inside the Interpreter
#715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced default `MAX_SIZE` to be 110kb. Reduced default `MAX_CONTRACT_SIZE` to be 100kb.
# Conflicts: # CHANGELOG.md # fuel-tx/src/builder.rs # fuel-tx/src/tests/valid_cases/transaction.rs # fuel-tx/src/transaction/consensus_parameters.rs # fuel-vm/src/checked_transaction.rs # fuel-vm/src/tests/limits.rs # fuel-vm/src/tests/validation.rs
…ed by all chargeable transactions
…ction # Conflicts: # fuel-tx/src/transaction/consensus_parameters.rs
# Conflicts: # fuel-tx/src/transaction/consensus_parameters.rs # fuel-vm/src/tests/validation.rs
…ansaction # Conflicts: # fuel-tx/src/transaction/types/script.rs # fuel-vm/src/interpreter.rs
Dentosal
reviewed
Apr 11, 2024
| @@ -96,6 +97,11 @@ impl<Ecal: EcalHandler> MemoryClient<Ecal> { | |||
| self.transactor.upgrade(tx) | |||
| } | |||
|
|
|||
| /// Executes `Upload` transaction. | |||
| pub fn upload(&mut self, tx: Checked<Upload>) -> Option<Upload> { | |||
There was a problem hiding this comment.
nit: Consider returning the error here instead of erasing it
Dentosal
previously approved these changes
Apr 11, 2024
… into feature/upload-transaction
…-transaction-within-interpreter # Conflicts: # fuel-vm/src/interpreter/executors/main/tests.rs
…-transaction-within-interpreter
…-transaction-within-interpreter
xgreenx
dismissed stale reviews from Dentosal and MitchTurner
The base branch was changed.
…interpreter # Conflicts: # CHANGELOG.md # fuel-tx/src/transaction/types/upload.rs
Dentosal
approved these changes
Apr 15, 2024
xgreenx
deleted the
feature/process-upload-transaction-within-interpreter
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the FuelLabs/fuel-core#1754
The
Interpretersupports the processing of theUploadtransaction. The change affectsInterpreterStorage, addingStorageMutate<UploadedBytes>constrain.Checklist
Before requesting review