Skip to content

feat(app): render platform experience (FS Embed) in iframe #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

pipopotamasu
Copy link
Collaborator

@pipopotamasu pipopotamasu commented Jan 29, 2025

This change enables users to use platform experience (FS Embed). This new experience is optional to use at this moment and it doesn't break the existing one.

// New 
const platformFeature = fullscriptClient.create("platform", options);

// This still works
const treatmentPlanFeature = fullscriptClient.create("treatmentPlan", options);

This change enables users to use platform experience (FS Embed). This new experience is optional to
use at this moment and it doesn't break the existing one.
);

expect(url).toEqual(
`https://us-snd.fullscript.io/api/embeddable/session/embed/entry?data_token=${encodeURIComponent(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/embed/entry is the entry point to launch platform experience (FS Embed)

@pipopotamasu pipopotamasu marked this pull request as ready for review February 6, 2025 18:35
@pipopotamasu pipopotamasu self-assigned this Feb 6, 2025
Copy link
Contributor

@charle692 charle692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me :) excited to start seeing this being used!

@pipopotamasu pipopotamasu merged commit 5e575e0 into master Feb 11, 2025
@pipopotamasu pipopotamasu deleted the platform_feature branch February 11, 2025 14:01
@fullscript-devops
Copy link
Collaborator

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants