Merge bhalsey/ENG-2184/sorted_domain_order #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wied03
approved these changes
Apr 22, 2025
wied03
added a commit
that referenced
this pull request
Apr 29, 2025
* client built with sorted domain types (#120) * reapply issue 1 changes --------- Co-authored-by: Brent Halsey <brent.halsey@fusionauth.io>
wied03
added a commit
that referenced
this pull request
Aug 14, 2025
* Client library updates from enums * latest client updates * Updated version for go-client to 1.55.0 * Domain / Client Builder sync * Domain sync * domain sync * Updated version for go-client to 1.56.0 * domain sync * Merge wied03/ENG-1/tenant-mode-internal-user-removal (#94) * Updated go client * api version removal * update without InternalUser * update without InternalUser part 2 * add top-level user.phoneNumber field ENG-2208 * merge develop into issue1 * updates from app (#97) * updates after cleanup (#98) * sync clients with latest degroff/ENG-1/issue1 * add LoginIdType of phoneNumber (#99) * Merge wied03/ENG-2307/user-api-response-verification (#100) * client builder/API updates * Update * generate for identity verification external id configuration * generate clients ENG-1918 * external Id updates * add phone verification complete template and unverified behavior * Merge wied03/ENG-1963/phone_gating (#106) * client updates and ignore internal TODOs and comments * Separate verify start and complete * update after verify request changes * one more phone rename * regenerate after merge * regen client libraries (#108) ENG-2442 * phone clickable updates (#109) * add new login API response field (#110) * add application.registrationConfiguration.requirePassword boolean (#115) * client regen * new API field (#117) * remove application requirePassword, add tenant passwordEnabled (#118) * updates (#119) * Merge wied03/dev_merge (#121) * client built with sorted domain types (#120) * reapply issue 1 changes --------- Co-authored-by: Brent Halsey <brent.halsey@fusionauth.io> * ENG-2608 - New APIs/method overloads (#124) * capture current cli state * test on all PRs * go generic String->string issue * Test this code path * add report method * make go format fail explicitly (was hiding an error) * now that this overload does not have opt params, remove defaults * Merge spencer/eng-1807/change-password-phone (#123) * forgot password via sms * regen clients * Merge wied03/ENG-2546/phone_passwordless_formfield (#126) * field rename * remove unneeded field * rename to PasswordlessLoginOneTimeCode * Merge wied03/ENG-2002/sms-send-set-pass (#127) * new API field * fail builds if compiles fail * add tenant phone verification and template configs (#128) * add state to verify complete response and start request (#130) * client builder sb build * Merge spencer/eng-2577/admin-phone-verif (#132) add /api/user/verify and request to clients * Merge wied03/ENG-1677/rate_limiting (#133) * rate limiting config change for pwless send phone * client update * wrong branch, another client update * updated stuff from issue 1 branch * remove VerifySendRequest.oneTimeCode. it is not used on that endpoint (#135) * add Application.phoneConfiguration for phone template overrides (#137) * sb build updates (#138) * add UserIdentityUpdateEvent (#139) * identity verified to user identity verified (#143) * remove passwordEnabled field (#142) * sb build follow up * Merge wied03/ENG-3045/import_verified (#151) * verifiedReason updates * ripple through comment updates * use enums on api requests (#154) * use PasswordlessStrategy enum for API request * use VerificationStrategy enum for API request * GHA ifs need to include success, or a previous step failure will not stop the run * match latest developer scripts * go mod tidy * roles property does not exist at the RegistrationRequest body level. It goes inside the registration --------- Co-authored-by: Daniel DeGroff <daniel@fusionauth.io> Co-authored-by: Spencer Witt <spencer@fusionauth.io> Co-authored-by: Brent Halsey <brent.halsey@fusionauth.io> Co-authored-by: Spencer Witt <3409780+spwitt@users.noreply.github.com> Co-authored-by: Brent Halsey <211656+bhalsey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Problem:
Every time we touch domain objects, the go and typescript clients get generated in a different order. This makes it impossible to determine what changed in client PRs. Furthermore, the order for a pegged version can vary from one developer to another.
This is a result of the domain objects getting loaded in from directory lists. The client generating freemarker then uses code like
[#list domain as d]to iterate over them.Solution:
Use the updated client builder, which sorts the domain objects by their "class" name (the last real name in a file like
io.fusionauth.domain.Tenant.jsonLinked PR: