Skip to content

Conversation

robotdan
Copy link
Member

  1. Allow the server to be configured to compress by default, and still allow the HTTP response to enable or disable compression.
  2. Change behavior of setHeader and addHeader in HTTPResonse, needs discussion.
  3. Javadoc

@robotdan robotdan requested a review from voidmain October 28, 2022 07:27

private final OutputStream unCompressingOutputStream;

private Boolean compress;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tri-state, so I may as well just make this an enum. [unset, true, false].

@robotdan robotdan merged commit e4ae033 into master Oct 28, 2022
@robotdan robotdan deleted the degroff/compress-by-default branch October 28, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants