Skip to content

Conversation

jamesbraza
Copy link
Collaborator

I missed this in #1023

@jamesbraza jamesbraza self-assigned this Jul 28, 2025
@Copilot Copilot AI review requested due to automatic review settings July 28, 2025 01:56
@jamesbraza jamesbraza added the bug Something isn't working label Jul 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the PyPDF package path to the mypy configuration, addressing an oversight from a previous pull request (#1023). The change ensures that mypy can properly type-check the paper-qa-pypdf package alongside the existing paper-qa-pymupdf package.

  • Added $MYPY_CONFIG_FILE_DIR/packages/paper-qa-pypdf/src to the mypy_path configuration

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 28, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 28, 2025
@jamesbraza jamesbraza merged commit dc0f60c into main Jul 28, 2025
6 checks passed
@jamesbraza jamesbraza deleted the fixing-missing-mypy branch July 28, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants