Skip to content

Fixing tests after 0 score prompt change #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2025
Merged

Fixing tests after 0 score prompt change #1108

merged 3 commits into from
Sep 26, 2025

Conversation

jamesbraza
Copy link
Collaborator

@jamesbraza jamesbraza commented Sep 26, 2025 •
edited
Loading

  • Hacking test_unrelated_context and test_images_corrupt by injecting nonzero relevance score
  • Refreshed a few cassettes that depend on summary_json_system_prompt

@jamesbraza jamesbraza requested a review from whitead September 26, 2025 00:32
@jamesbraza jamesbraza self-assigned this Sep 26, 2025
@jamesbraza jamesbraza added the bug Something isn't working label Sep 26, 2025
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 26, 2025
@jamesbraza jamesbraza force-pushed the comments-json-change-2 branch from 7d4ccf8 to 7a11ebe Compare September 26, 2025 00:45
@jamesbraza jamesbraza merged commit 4612495 into json-change Sep 26, 2025
5 checks passed
@jamesbraza jamesbraza deleted the comments-json-change-2 branch September 26, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead Awaiting requested review from whitead

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesbraza