Skip to content

Propagating citation count in flaky test_pdf_reader_match_doc_details #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Propagating citation count in flaky test_pdf_reader_match_doc_details #766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/test_paperqa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,8 @@ def test_pdf_reader_match_doc_details(stub_data_dir: Path) -> None:
r"This article has (\d+) citations", doc_details.formatted_citation
)
assert match
assert int(match.group(1)) >= 1, "Expected at least one citation"
num_citations = int(match.group(1))
assert num_citations >= 1, "Expected at least one citation"
assert (
"Journal of Chemical Theory and Computation" in doc_details.formatted_citation
)
Expand All @@ -954,7 +955,7 @@ def test_pdf_reader_match_doc_details(stub_data_dir: Path) -> None:
for _ in range(num_retries):
answer = docs.query("Are counterfactuals actionable? [yes/no]")
if any(w in answer.answer for w in ("yes", "Yes")):
assert "This article has 23 citations" in answer.context
assert f"This article has {num_citations} citations" in answer.context
return
raise AssertionError(f"Query was incorrect across {num_retries} retries.")

Expand Down
Loading