Add clinical trials search tool #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XXL
jamesbraza
reviewed
Dec 24, 2024
| }, | ||
| ) as response: | ||
| if response.status == MALFORMATTED_QUERY_STATUS: | ||
| # the 400s from clinicaltrials.gov are not JSON |
There was a problem hiding this comment.
Do you mind moving this comment to live with MALFORMATTED_QUERY_STATUS, or renaming MALFORMATTED_QUERY_STATUS to be CLINICAL_TRIALS_DIDNT_GIVE_JSON = 400
There was a problem hiding this comment.
But this comment is about the decoding, not the status (i.e. the code being 400 means it's malformed but the clinicaltrials.gov response isn't JSON in that case), so it really applies to running .json() vs. .text() on the response object.
jamesbraza
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstreams FutureHouse's clinical trials search tool to make it open source. The tool is not turned on by default, but I'm going to make more docs on how to use the tool as well.
I also found many typing regressions -- I've added those back in where necessary.