Skip to content

Converting add_texts_and_embeddings to async #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 30, 2024
Merged

Converting add_texts_and_embeddings to async #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
07a893f
Converting `add_texts_and_embeddings` to async
ThomasRochefortB Dec 23, 2024
a53d288
Added await
ThomasRochefortB Dec 30, 2024
6723630
Merge branch 'main' into feat/async_add_texts_embed
ThomasRochefortB Dec 30, 2024
80d877b
Fixed the mypy type error
ThomasRochefortB Dec 30, 2024
bd6ad9b
Merge branch 'feat/async_add_texts_embed' of https://github.com/Thoma…
ThomasRochefortB Dec 30, 2024
8ad6849
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Dec 30, 2024
4a4ee57
Revert "Fixed the mypy type error"
jamesbraza Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paperqa/docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ async def _build_texts_index(self, embedding_model: EmbeddingModel) -> None:
strict=True,
):
t.embedding = t_embedding
self.texts_index.add_texts_and_embeddings(texts)
await self.texts_index.add_texts_and_embeddings(texts)

async def retrieve_texts(
self,
Expand Down
11 changes: 6 additions & 5 deletions paperqa/llms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ def __len__(self) -> int:
return len(self.texts_hashes)

@abstractmethod
def add_texts_and_embeddings(self, texts: Iterable[Embeddable]) -> None:
async def add_texts_and_embeddings(self, texts: Iterable[Embeddable]) -> None:
"""Add texts and their embeddings to the store."""
self.texts_hashes.update(hash(t) for t in texts)

@abstractmethod
Expand Down Expand Up @@ -198,8 +199,8 @@ def clear(self) -> None:
self._embeddings_matrix = None
self._texts_filter = None

def add_texts_and_embeddings(self, texts: Iterable[Embeddable]) -> None:
super().add_texts_and_embeddings(texts)
async def add_texts_and_embeddings(self, texts: Iterable[Embeddable]) -> None:
await super().add_texts_and_embeddings(texts)
self.texts.extend(texts)
self._embeddings_matrix = np.array([t.embedding for t in self.texts])

Expand Down Expand Up @@ -328,8 +329,8 @@ def clear(self) -> None:
)
self._point_ids = None

def add_texts_and_embeddings(self, texts: Iterable[Embeddable]) -> None:
super().add_texts_and_embeddings(texts)
async def add_texts_and_embeddings(self, texts: Iterable[Embeddable]) -> None:
await super().add_texts_and_embeddings(texts)

texts_list = list(texts)

Expand Down
Loading