Skip to content

Fixed Record import from Qdrant not being in TYPE_CHECKING block #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2025
Merged

Fixed Record import from Qdrant not being in TYPE_CHECKING block #791

merged 3 commits into from
Jan 6, 2025

Conversation

jamesbraza
Copy link
Collaborator

@jamesbraza jamesbraza commented Jan 6, 2025 •
edited
Loading

When not using Qdrant, installers as of v5.9.0 will get this error:

.venv/lib/python3.12/site-packages/paperqa/llms.py:35: in <module>
    from qdrant_client.http.models import Record
E   ModuleNotFoundError: No module named 'qdrant_client'

This PR:

  • Fixes the non-lazily imported type hint
  • Removed an unnecessary from __future__ import annotations

@jamesbraza jamesbraza added the bug Something isn't working label Jan 6, 2025
@jamesbraza jamesbraza requested a review from a team January 6, 2025 19:31
@jamesbraza jamesbraza self-assigned this Jan 6, 2025
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 6, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 6, 2025
@jamesbraza jamesbraza mentioned this pull request Jan 6, 2025
Merged
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 6, 2025
ThomasRochefortB
ThomasRochefortB approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@ThomasRochefortB ThomasRochefortB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it passes the QdrantVectorStore unit tests on my local

@jamesbraza jamesbraza merged commit 2d1f7ca into main Jan 6, 2025
5 checks passed
@jamesbraza jamesbraza deleted the qdrant-import-to-type-checking branch January 6, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mskarlin mskarlin mskarlin approved these changes

+1 more reviewer

@ThomasRochefortB ThomasRochefortB ThomasRochefortB approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesbraza @mskarlin @ThomasRochefortB